Scan setting phy is irrelevant

[clackmac]

This is not exactly an issue, but wanted to mentioned that on the TcnBluetoothManager, there's:

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
   setPhy(ScanSettings.PHY_LE_ALL_SUPPORTED)
    setLegacy(true)
}

But the documentation clearly states: This is used only if ScanSettings.Builder#setLegacy is set to false.

[ivnsch]

Thanks for pointing it out! There's other point here that would be interesting to clarify:

The doc of setLegacy states:

Set whether only legacy advertisments should be returned in scan results.

Why are we interested in only legacy advertisements?
@zssz