TF-RMM/tf-rmm

Multi Config generator build is broken

Closed this issue · 2 comments

soby-mathew commented

The TF-RMM Cmake build system allows to build via the Ninja multi config generator. But this is broken by a recent change. The build log is as follows :

cmake -DRMM_CONFIG="fvp_defcfg" -S . -B build -G"Ninja Multi-Config" -DCMAKE_VERBOSE_MAKEFILE=1
-- The C compiler identification is GNU 10.3.1
-- The CXX compiler identification is GNU 10.3.1
-- The ASM compiler identification is GNU
-- Found assembler: /work/tools/gcc-arm-10.3-2021.07-x86_64-aarch64-none-elf/bin/aarch64-none-elf-gcc
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /work/tools/gcc-arm-10.3-2021.07-x86_64-aarch64-none-elf/bin/aarch64-none-elf-gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /work/tools/gcc-arm-10.3-2021.07-x86_64-aarch64-none-elf/bin/aarch64-none-elf-c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Git: /usr/bin/git (found version "2.25.1") 
CMake Error at cmake/Modules/ArmConfigOption.cmake:281 (if):
  if given arguments:

    "STREQUAL" "Release"

  Unknown arguments specified
Call Stack (most recent call first):
  lib/debug/CMakeLists.txt:12 (arm_config_option)


-- Configuring incomplete, errors occurred!
See also "/work/github/rmm/rmm/build/CMakeFiles/CMakeOutput.log".
See also "/work/github/rmm/rmm/build/CMakeFiles/CMakeError.log".

The regression was introduced at this patch : 7c38ef4

soby-mathew commented

The issue is that CMAKE_BUILD_TYPE variable should not be used for multi config build.