TNG/ngqp

Need Ivy support

PxyUp opened this issue · 5 comments

PxyUp commented

Hello, first of all, thank you very much for really nice library it works perfectly, but after migration on 9 angular it is not working(i enable ivy). May be team can be provide that support:

    ERROR in node_modules/@ngqp/core/lib/query-param.module.d.ts:3:22 - error NG6002: Appears in the NgModule.imports of ApplicationsModule, but could not be resolved to an NgModule class.
    
    This likely means that the library (@ngqp/core) which declares QueryParamModule has not been processed correctly by ngcc, or is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.
PxyUp commented

If it will help for you i can provide MR

Thanks for reporting this issue! Which version exactly are you using of ngqp according to your lock file? Can you try reinstalling it? I use ngqp on an Ivy project myself so I do know that it works in general. :-)

PxyUp commented
    "@ngqp/core": {
      "version": "1.0.2",
      "resolved": "https://registry.npmjs.org/@ngqp/core/-/core-1.0.2.tgz",
      "integrity": "sha512-NJ5ktrQwv7mRsmcOlA2ueTceI+vThSKhiQEzSJIlLtcHCLE26S7Zb8h4Gn40KlPYxC58fROGRAHqHKW6wdbcYw==",
      "requires": {
        "schematics-utilities": "^1.1.2",
        "tslib": "^1.9.0"
      }
    },
PxyUp commented

Sorry my bad, i move it lazy load module ;)

Glad you got it to work!