Comment box isn't always recolouring
Closed this issue · 23 comments
Sometimes I am getting this view when refreshing a list of incidents. This is happening since a few days
It also happens for me.
Frame around the table is white, the buttons above are in original color and the comment box is white and unreadable.
I have also issue with reinstalling of Stylus. When clicking on Install *** theme it only opens the .css raw file.
@Schekk95 and @robert98983 Thanks for bringing this to my attention! I'm not sure what is going on as of yet but I can fortunately reproduce both issues.
There haven't been any changes recently from my end, so I'll have to look into what is happening.
The issue with opening the .user.css file not being picked up by Stylus, seems to be an issue on their end. I found a recent mention of the issue on their discord, and it looks like the problem has already been fixed but is waiting for release.
Seems like it is happening after a new Chrome update released around last weekend.
Also when pasting code into stylus it throws like 800 errors. Most errors consist of missing commas
It may be Chromium-based issue. I am working in Edge.
Same here in chrome
Sometimes white parts appear on the site
I have to refresh or click gear icon within topdesk for theme to refresh
Switched to firefox and its even worse, the theme never seems to fully load and have to disable the theme in stylus and enable it again and then it applies until I open some new tab
There is something about the theme not applying until its disabled and enabled
@Neoony Interesting that it happens to you in Firefox too.
I've been able to test with a colleague, and they did not have the issue. So this all seems to exclude the browser as the culprit.
In firefox it seems like a different problem than in chrome
In firefox the theme is basically not applying, until you disable and enable it..every time you load a page
In chrome its just some part of the theme sometimes not applying
I am just in process of switching from chrome to FF at my work laptop
Anyways to sum it up with some images:
Default Dark
In Chrome this sometimes happens, for example when I open my First Lines (started happening quite recently)
(the white part)
In firefox this happens pretty much every new tab open or whenever I load topdesk:
Then I disable enable the theme and the theme loads, only until new tab or loading topdesk again
Worth noting that on login screen the theme seems to be applied, but after logging in the theme is only visible for split second and then switches to default non-stylus
Also disabled any other extensions, no change
FF is freshly "installed" portable 113.0.1 (64-bit)
Stylus 1.5.31
Currently mainly interested in somehow fixing the FF
@Neoony Thanks for the screenshots and details!
I can reproduce your FF issue, but only when I use Firefox from portableapps. I can see the style gets applied to the page, since the quicklaunch and tab bar have changed colours. But for some reason it is not applied to every iframe, until you cause a refresh of the style.
Indeed since I dont have Administrator access, I can only use Portable FF
Its using much less memory than Chrome for me, which is one of the reasons why I am trying to switch.
Any idea if there is something that can be done about it?
@Schekk95 Those 800+ warnings are nothing to worry about. Stylus is worried the linebreak means you must have forgotten a comma, which would start a new selector, but in reality the linebreak is intentional to keep the massive selectors that are needed somewhat readable.
I've been investigating the issues, and it comes down to the styling just not getting applied. In Chrome Stylus only applies a single section, and in (Portable) Firefox it doesn't apply any styles to any of the inner iframes.
With the Chrome issue, clicking the gear icon causes another iframe to be drawn, which seems to trigger a re-evaluation, similar to disabling and re-enabling the styles.
I have posed the question to the Stylus maintainers, to see if they can shed light on what might have changed recently. Unfortunately, I have not been able to reproduce either issue in small scale, so I can't present them with a reproduction recipe.
@Neoony It looks like Stylus has fixed the issue for Portable FireFox in version 1.5.32. Testing with a development version all styles were applied as intended. It has been released 5 hours ago, so give it a little time to propagate through all the channels.
Unfortunately, this does not seem to fix the issue with Chrome.
I have been able to identify the commit in Stylus that introduces the issue in Chrome!
I have filed a bug on their issue tracker to address the issue.
@Neoony It looks like Stylus has fixed the issue for Portable FireFox in version 1.5.32. Testing with a development version all styles were applied as intended. It has been released 5 hours ago, so give it a little time to propagate through all the channels.
Unfortunately, this does not seem to fix the issue with Chrome.
Awesome.
Thanks a lot. I will have to confirm on Friday.
Stylus maintainers have created a fix for the Chrome issue! Waiting for next release...
Added a patch for the Chrome issue (thanks to toph from Stylus), awaiting the proper solution to land in Stylus.
It looks like the fix for Firefox has not yet landed in the update channels.
Stylus version 1.5.33 has made it into the Chrome web store, so the problem should be fixed there now. I'll be removing the temporary fix in due time.
Unfortunately, the version update is still stuck in the review process at Firefox.
Yeah the FF is taking a long time
Really wish they had Direct Download on their website as well. I guess I would have to compile it myself
@Neoony If you'd like you could temporarily install the master build, it's pretty straightforward, you'll just not get automatic Stylus updates I think.
Ah didnt notice that guide, Thanks.
Yeah I think I will have to load it every time I load firefox. Semi Permanent install does not seem to work (verification failed, that signatures setting is not helping)
But thats fine, just until the update is out for FF.
@Neoony The Stylus FireFox Add-on page shows 1.5.33, so it should be fixed now!
Yep, everything working great.
Thx for all the support.