CapFrac does not work as specified if c0 is not ~0
lightningclaw001 opened this issue · 5 comments
lightningclaw001 commented
CapFrac does not work as specified if c0 is not ~0
d-cogswell commented
Maybe now is a good time to remove capFrac. It has been deprecated since 0.1.4.
lightningclaw001 commented
i feel like capfrac is still useful (like for example, if we use NMC batteries that need to be cut off at a certain voltage or capacity), are you sure we should just remove it?
d-cogswell commented
The limits we need are voltage, time, and capacity. Right now we have voltage and time, and it would be good to add capacity. capfrac is really just another (confusing) way of implementing a time cutoff.
lightningclaw001 commented
yes, that makes sense! i will just remove it in this issue then.
lightningclaw001 commented
i think most of the test cases have capFrac in them so it changes the test case solutions, should we just rewrite all the test cases?