CapFrac does not work as specified if c0 is not ~0

Question

CapFrac does not work as specified if c0 is not ~0

lightningclaw001 opened this issue 3 years ago · 5 comments

Answer 1 · 2021-07-27T00:43:48.000Z

Maybe now is a good time to remove capFrac. It has been deprecated since 0.1.4.

Answer 2 · 2021-07-27T17:07:27.000Z

i feel like capfrac is still useful (like for example, if we use NMC batteries that need to be cut off at a certain voltage or capacity), are you sure we should just remove it?

Answer 3 · 2021-07-27T19:29:20.000Z

The limits we need are voltage, time, and capacity. Right now we have voltage and time, and it would be good to add capacity. capfrac is really just another (confusing) way of implementing a time cutoff.

Answer 4 · 2021-07-27T21:58:57.000Z

yes, that makes sense! i will just remove it in this issue then.

Answer 5 · 2021-07-27T22:35:06.000Z

i think most of the test cases have capFrac in them so it changes the test case solutions, should we just rewrite all the test cases?