TStand90/tcod_tutorial_v2

render_functions.py : get_names_at_location Capitalization

Opened this issue · 1 comments

In the function, names is capitalized after joined together. If there are two entities there only first letter is capitalized.
It is better to capitalize then join them.

From: (Player remains of troll)

names = ", ".join(
        entity.name for entity in game_map.entities if entity.x == x and entity.y == y
    )

    return names.capitalize()

To: (Player Remains of troll)

names = ", ".join(entity.name.capitalize() for entity in game_map.entities
                      if entity.x == x and entity.y == y)

    return names

Technically I think the previous grammar is correct. At least in English a comma doesn't automatically capitalize the next letter.

The all-caps version does look a little bit better, but maybe that's subjective.