Evaluate performance of identifier extraction
Opened this issue · 2 comments
physikerwelt commented
The length of
https://github.com/TU-Berlin/project-mlp/blob/master/mlp/src/test/java/mlp/text/MathMLUtilsTest.java#L77-77
should be 3, but it's actually 0.
Do I miss something?
alexeygrigorev commented
I don't remember why it's 0, because the assert doesn't quite makes sense for an empty set... anyways the test checks that if the msub expression is too complex, it doesn't produce garbage. And actually if the complex msub wasn't discarded, it appears that the set would contain 1 element.
alexeygrigorev commented
Just to clarify, an identifier is something in <mi>, not inside of <msub> or <msub> - it's done to avoid capturing non-identifiers. E.g.