TUM-Dev/Campus-Android

MainScreen / CardView customization not working [BUG]

kunzef opened this issue · 1 comments

kunzef commented

Describe the bug
Multiple bugs with the MainScreen / CardView customization

  1. On first start MensaCard not displayed but enabled in Settings. Appears after opening Settings once

  2. Removing a Card by swiping does not work for certain instances of NewsCard and the MensaCard. The Settings of the removed Cards are not updated.

  3. Restore cards does not work at all. After exiting the CardView and reentering it the Restore cards button is not visible.

  4. There are more bugs than the ones listed above including variations of the above ones as different Cards are behaving differently. I will subsequently add them to this issue. There are also more different Cards and thus more bugs when the user is logged in. Because I had to delete the App data every time as Restore cards does not work I have not yet included these.

To Reproduce
Steps to reproduce the behavior:

Bug 1 Bug 2 Bug 3
https://github.com/TUM-Dev/Campus-Android/assets/45203772/93336b27-f562-4036-9843-2d35f948657f https://github.com/TUM-Dev/Campus-Android/assets/45203772/fbdd8c81-c161-47ec-8655-8e24c99a4269 https://github.com/TUM-Dev/Campus-Android/assets/45203772/6f21e5d5-c935-4b18-a5c4-e75da99e5992

Smartphone (please complete the following information):

  • Phone: Google Pixel 6
  • OS version: 13
  • Language: Tried both English and German

Speculated reasons

  • diveregence between CardView and Settings may be the result of different locations of the SharedPreferences
kunzef commented

Upon further investigation I think that the behaviour of the App mentioned under 2. is partly intended. Meaning that when swiping, the card should only hide temporary and only when selecting Always hide card it should never be displayed again. But still the mensa card instantly reappears which I do think is not the correct behaviour. I also believe that the difference between swiping and always hiding should be made more clear.