Tahul/pinceau

Z-index pixel unit

KatsanKat opened this issue · 1 comments

Hello !
I noticed from the playground theme that the zIndex values are written in pixel unit :

zIndex: {
0: '0',
1: '1px',
2: '2px',
4: '4px',
6: '6px',
8: '8px',
10: '10px',
12: '12px',
16: '16px',
20: '20px',
24: '24px',
32: '32px',
40: '40px',
44: '44px',
48: '48px',
56: '56px',
64: '64px',
80: '80px',
104: '104px',
140: '140px',
200: '200px',
},

Since the mdn doc specified that z-index only supports integers,
is there a particular reason you choosed to define it with px or is it a mistake ?

Hello ! I noticed from the playground theme that the zIndex values are written in pixel unit :

zIndex: {
0: '0',
1: '1px',
2: '2px',
4: '4px',
6: '6px',
8: '8px',
10: '10px',
12: '12px',
16: '16px',
20: '20px',
24: '24px',
32: '32px',
40: '40px',
44: '44px',
48: '48px',
56: '56px',
64: '64px',
80: '80px',
104: '104px',
140: '140px',
200: '200px',
},

Since the mdn doc specified that z-index only supports integers, is there a particular reason you choosed to define it with px or is it a mistake ?

This should be a copy-paste error. I noticed that the value of z-index is the same as the value of space, so it was likely copied by mistake. I made a PR for this. https://github.com/Tahul/pinceau/pull/69/files