Taitava/silverstripe-cmseditlink

SiteTree links disappear with SS4.11/412

Opened this issue · 2 comments

elkebe commented

Upgrade from SS4.10 to SS4.12. It appears to all work fine via composer update and running dev/build, but when you go into the CMS pages section, all the links within the site tree are missing - page titles, structure etc all looks normal, just can’t click on any of the titles to open and edit a page. Can access a page via the browser by typing in the link, but can’t click in the site tree itself.

When extension is disabled in yml file, site tree links all work again:
SilverStripe\ORM\DataObject:
extensions:
#- Taitava\CMSEditLink\DataObjectExtension

The same happens with upgrade to SS4.11

More info see: https://forum.silverstripe.org/t/sitetree-links-missing-after-upgrading-from-ss4-10-4-11-12/6914

ntd commented

The method provided by the above extension (CMSEditLink) returns a CMSEditLink object and directly clashes with what expected by modern silverstripe-framework, where a string needs to be returned instead, see e.g. CMSEditLinkExtension or CMSPreviewable.

Hi @elkebe and @ntd ! 🙂 Due to changing job a few years ago, I do not work on SilverStripe projects anymore. If there's anyone willing to take over authoring this plugin, please let me know and I can probably transfer the overwnership of this repository.