Talend/ui

CMF: Action are referenced by to many differents props

acateland opened this issue · 2 comments

On some components CMFAction are resolved by props.id, props.name, props.actionIds

One point, no standard html properties should be used for the internal working of CMF.

Second point only one props name should be used to resolve CMFActions.

Third point, we need to document each usage of props that do not respect proposal one and two.

Fourth point, i propose cmfActionId as the only props that should be used to pass CMFAction indentifier for the sake of its resolution.

Fith we need to fix this.

actionId is already supported why change that ?
actionIds is not public but should be internal for stuff like dropdown which is a set of action so to build items as actions. it means it should not resolve on ownProps but on stateProps

I would say CMF should never use native props. (name and id are native props)

CMF actions API are deprecated
👍 we don t use any native html properties now internally in CMF
Need to cleanup containers now