Filter shows meals that do not have an explicit diet

Question

Filter shows meals that do not have an explicit diet

Closed this issue 3 months ago · 3 comments

LukasPietzschmann commented 3 months ago

I think the salad and desert 😉 should not be shown.

Answer 1 · 2024-07-31T09:14:17.000Z

Fun fact: when I run the site locally, this issue isn't present.
My local deployment uses commit 9647622

Answer 2 · 2024-07-31T09:21:36.000Z

It's not present in your deployment, as you have to use commit 9678a2a.

I thought that it would be better when meals without a meal type are shown in all filters. We could change it so that they are only shown in "unrestricted".

Answer 3 · 2024-07-31T09:33:31.000Z

OMG I for sure though I did a git pull and that 9647622 was the HEAD commit.

I think showing a meal that has no diet set, when I specifically filtered for meals that adhere to it, is kinda weird. But ultimately you decide :)