Bot ends lobbies for inactivity during active games

Question

Bot ends lobbies for inactivity during active games

Closed this issue 4 years ago · 16 comments

Bug Report

The bot will end a lobby stating "Nothing has happened 30 minutes, so I ended the lobby." despite the lobby being actively in use for a game. Bot automatically unmutes everyone when it occurs, proceeds to mute everyone as per usual after a state change in the game. Attempting to use "!sau stop" to close the lobby after this bug appears has the bot say "There's not a lobby for your voice channel. Try !sau start!"

Steps to Reproduce

Play games with the bot running alongside Among Us Capture.
Eventually (Feels like it might be around the 30 minute mark but not confirmed) bot will claim to close the lobby.

Expected behavior

Bot should detect the game as still running and not end lobby

Screenshots

https://imgur.com/a/350CUOK

Answer 1 · 2020-10-19T12:42:50.000Z

I think the 30 minute limit is too short. I'll double it in the next version.

But are you saying that it still responds to game commands after it's supposedly ended the lobby for inactivity?

Also, are you using AmongUsCapture, or running it manually?

Answer 2 · 2020-10-19T16:24:55.000Z

I'm using it alongside AmongUsCapture, and when AmongUsCapture updates the game state (going from in meeting back to in game for example) the bot reacts correctly. It seems like the bot ends the lobby and unmutes all players, but still handles muting and unmuting correctly once the game state changes. I haven't tested to see if it would respond to manual commands once it ends the lobby, but trying to issue a command to stop the lobby doesn't work, which made making new lobbies a little weird. I'm not sure that the time limit is too short, as we never had a 30 minute period where nothing at all happened. The only time the limit came to our attention was when it was killing the lobby mid game.

…

On Mon, Oct 19, 2020 at 11:43 PM James Tanner ***@***.***> wrote: I think the 30 minute limit is too short. I'll double it in the next version. But are you saying that it still responds to game commands after it's supposedly ended the lobby for inactivity? Also, are you using AmongUsCapture, or running it manually? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#16 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARN2EY4SJHYLAE2SYQD2EOLSLQX5XANCNFSM4SWCN3LQ> .

Answer 3 · 2020-10-19T17:49:20.000Z

Hrm. Any updates from the capture should be resetting the 30-minute timer as well.

What's even more strange is that it can still manage the lobby after it's stopped. The lobby shouldn't even exist anymore for it to be updating it. But it would seem that it's only half deleted.

I've noticed some other strange behavior too, so I think I need to re-evaluate how lobbies are stored, loaded, and updated. (Unfortunately, I wasn't able to replicate this myself. My group played for several hours without encountering it.)

Answer 4 · 2020-10-22T17:55:18.000Z

I have the same problem, after 30 minutes, the bot stop the lobby but unmute mute when someonedead or call an emergencycall.

I think the bot don't reset the timer when we use AmongUsCapture

Answer 5 · 2020-10-22T18:05:53.000Z

BaDy17 commented 4 years ago

Answer 6 · 2020-10-22T18:14:53.000Z

I think the bot don't reset the timer when we use AmongUsCapture

It's weirder than that. Because the lobby shouldn't still work after it's been timed out. It shouldn't be accepting updates from the bot either.

Answer 7 · 2020-10-22T18:25:35.000Z

I know that and if I try !sau stop it answers "There"s not a lobby..."

If I continue to play another game the bot continues to close the lobby again after a certain time.

And again and again. I can't "stop" and if I start a new lobby I have the same situation after some minutes.

It's like the bot stacks the same lobby after updates (dead, emergencycall, etc) and close all lobbys after x time

Answer 8 · 2020-10-22T21:49:15.000Z

So far, I've confirmed a couple things:

The lobby IS destroyed by the timeout. (So that needs to be longer.)
Destroyed lobbies are removed from lobbiesByVoiceChannel and the backup database.
Destroyed lobbies are not removed from lobbiesByConnectCode, because the socket is still able to update it.

For example, this is what happens if I let my lobby timeout and then change my color:

Answer 9 · 2020-10-22T22:08:50.000Z

This issue is resolved in version 2.3.0

Answer 10 · 2020-10-23T13:37:24.000Z

Heads up, seems like it hasn't been fully resolved as we just had it happen again in our game.

https://imgur.com/a/j4EUbvT

Answer 11 · 2020-10-23T14:00:26.000Z

Hrm. Can you use !sau version for me?

(FYI: you can paste images directly into Github comments. No need for Imgur.)

Answer 12 · 2020-10-24T02:49:20.000Z

Oh, didn't even realise I could directly comment a photo.
The bot reports version 2.5.2

Answer 13 · 2020-10-24T02:52:11.000Z

I've had two lobbies running in parallel for the last 5+ hours, with no issues. Are you sure this is still occurring?

(I did recently fix a bug in which a stopped lobby would post in Discord that it had timed out, about an hour after it was stopped.)

Answer 14 · 2020-10-24T02:57:48.000Z

Unless somewhere in between 2.3.0 and now you've fixed this issue again, it definitely still occurs.

That last screenshot I sent shows the bot ending the lobby, the bot updating the same lobby moments later and then me trying to use '!sau lobby' to double check if the same issue occurred. The exact same behaviour showed up as before the first fix.

For what it's worth, we were playing for about 5 hours last night and had the issue pop up twice, which is significantly less frequent than it was happening before

Answer 15 · 2020-10-27T02:24:20.000Z

I'm still not able to replicate this at all, unfortunately.

If you encounter it again, can you give me an exact (as possible) time when it happened? (Make sure to include a timezone).
I'll also need your Discord server ID.

Answer 16 · 2020-10-27T02:40:17.000Z

Sure can. I havent actually had a chance to play since it last popped up, but if I encounter it again I'll give you all the info I can.