Tanuki/tanuki.py

Add a top-level config parameter to disable telemetry.

Closed this issue · 3 comments

JackHopkins commented

Currently, we automatically track usage of MP to help understand how people are using it.

There is currently no way to turn this off. Users may want to disable telemetry for privacy reasons.

We should add a top-level global config parameter for users to opt-out if necessary. The syntax could look something like this:

Monkey.telemetry(disable=True)
JackHopkins commented

Actually, this should be added as a new *kwarg to the existing (newly added) Monkey.configure global method:

monkey.configure(disable_telemetry=True)
cosmastech commented

@JackHopkins where is the configure method defined? I don't see it within src/monkey.py

cosmastech commented

A couple of thoughts on telemetry @JackHopkins:

Should there be a reasonable timeout for telemetry? And/or can the request be done async? Or deferred?

My thinking is that as it's written now, isn't this blocking the thread waiting for a response? While it's easy enough to disable telemetry (now 😃), seems like it would be nice so that it's as unobtrusive as possible for those who leave it on