Tawmy/xivapi-cs

Add two minimal characters to unit tests

Closed this issue · 0 comments

Tawmy commented

As of right now, the unit tests usually test for ten different characters. These characters are either still active, or if they're inactive, have still played the game for some time.

To make sure all values marked as non-nullable can actually never be empty, two more characters should be created in-game and added to the unit tests.

  • A character that was just created and has not yet watched the first cutscene
  • A character that has done nothing apart from completing the first basic tutorial so they can see other players

Once these two are added, the unit tests should fully cover all nullable properties on characters. They need to be added to all character related tests:

  • CharacterProfileAchievements
  • CharacterProfileExtendedComplete
  • CharacterProfileFriends
  • CharacterProfileMimo
  • CharacterProfile
  • CharacterSearch

Closes #1