Taymindis/nginx-link-function

Make header installation after building

nmdnm opened this issue · 4 comments

nmdnm commented

Please remove the installation of the header file before building, this requires the use of dirty hacks or a patch when writing the package build script, this is what I found on the Internet trying to solve my problem with creating the package:
https://bbs.archlinux.org/viewtopic.php?pid=1776925
https://svnweb.freebsd.org/ports/head/www/nginx/files/extra-patch-nginx-link-function-config?view=markup

Taymindis commented

hi @vikaig

did you mean remove the header validation before configuring nginx? If I remove it, nobody will be aware this need to be installed. Do you have any suggestion?

From the building script, it's just for the reminding to install header, it doesn't help you to install. Does it impact any procedure? Please do let me know if i can help

nmdnm commented

in my case this reminder causes return status 1 when executed ./configure --with-compat --add-dynamic-module=../nginx-link-function-3.2.3

...
==> Starting build()...
checking for OS
 + Linux 5.6.15-arch1-1 x86_64
checking for C compiler ... found
 + using GNU C compiler
checking for -Wl,-E switch ... found
checking for gcc builtin atomic operations ... found
checking for C99 variadic macros ... found
checking for gcc variadic macros ... found
checking for gcc builtin 64 bit byteswap ... found
checking for unistd.h ... found
checking for inttypes.h ... found
checking for limits.h ... found
checking for sys/filio.h ... not found
checking for sys/param.h ... found
checking for sys/mount.h ... found
checking for sys/statvfs.h ... found
checking for crypt.h ... found
checking for Linux specific features
checking for epoll ... found
checking for EPOLLRDHUP ... found
checking for EPOLLEXCLUSIVE ... found
checking for O_PATH ... found
checking for sendfile() ... found
checking for sendfile64() ... found
checking for sys/prctl.h ... found
checking for prctl(PR_SET_DUMPABLE) ... found
checking for prctl(PR_SET_KEEPCAPS) ... found
checking for capabilities ... found
checking for crypt_r() ... found
checking for sys/vfs.h ... found
checking for nobody group ... found
checking for poll() ... found
checking for /dev/poll ... not found
checking for kqueue ... not found
checking for crypt() ... not found
checking for crypt() in libcrypt ... found
checking for F_READAHEAD ... not found
checking for posix_fadvise() ... found
checking for O_DIRECT ... found
checking for F_NOCACHE ... not found
checking for directio() ... not found
checking for statfs() ... found
checking for statvfs() ... found
checking for dlopen() ... not found
checking for dlopen() in libdl ... found
checking for sched_yield() ... found
checking for sched_setaffinity() ... found
checking for SO_SETFIB ... not found
checking for SO_REUSEPORT ... found
checking for SO_ACCEPTFILTER ... not found
checking for SO_BINDANY ... not found
checking for IP_TRANSPARENT ... found
checking for IP_BINDANY ... not found
checking for IP_BIND_ADDRESS_NO_PORT ... found
checking for IP_RECVDSTADDR ... not found
checking for IP_SENDSRCADDR ... not found
checking for IP_PKTINFO ... found
checking for IPV6_RECVPKTINFO ... found
checking for TCP_DEFER_ACCEPT ... found
checking for TCP_KEEPIDLE ... found
checking for TCP_FASTOPEN ... found
checking for TCP_INFO ... found
checking for accept4() ... found
checking for eventfd() ... found
checking for int size ... 4 bytes
checking for long size ... 8 bytes
checking for long long size ... 8 bytes
checking for void * size ... 8 bytes
checking for uint32_t ... found
checking for uint64_t ... found
checking for sig_atomic_t ... found
checking for sig_atomic_t size ... 4 bytes
checking for socklen_t ... found
checking for in_addr_t ... found
checking for in_port_t ... found
checking for rlim_t ... found
checking for uintptr_t ... uintptr_t found
checking for system byte ordering ... little endian
checking for size_t size ... 8 bytes
checking for off_t size ... 8 bytes
checking for time_t size ... 8 bytes
checking for AF_INET6 ... found
checking for setproctitle() ... not found
checking for pread() ... found
checking for pwrite() ... found
checking for pwritev() ... found
checking for sys_nerr ... found
checking for localtime_r() ... found
checking for clock_gettime(CLOCK_MONOTONIC) ... found
checking for posix_memalign() ... found
checking for memalign() ... found
checking for mmap(MAP_ANON|MAP_SHARED) ... found
checking for mmap("/dev/zero", MAP_SHARED) ... found
checking for System V shared memory ... found
checking for POSIX semaphores ... not found
checking for POSIX semaphores in libpthread ... found
checking for struct msghdr.msg_control ... found
checking for ioctl(FIONBIO) ... found
checking for ioctl(FIONREAD) ... found
checking for struct tm.tm_gmtoff ... found
checking for struct dirent.d_namlen ... not found
checking for struct dirent.d_type ... found
checking for sysconf(_SC_NPROCESSORS_ONLN) ... found
checking for sysconf(_SC_LEVEL1_DCACHE_LINESIZE) ... found
checking for openat(), fstatat() ... found
checking for getaddrinfo() ... found
configuring additional dynamic modules
adding module in ../nginx-link-function-3.2.3
checking for ngx_http_link_func ... not found
ngx_link_func_module.h not found in your system c header path, please copy latest ngx_link_func_module.h to your /usr/include or /usr/include or relavent header search path with read and write permission given.
e.g install -m 644 ../nginx-link-function/src/ngx_link_func_module.h /usr/include/

==> ERROR: A failure occurred in build().
    Aborting...

My WIP PKGBUILD:

pkgver=3.2.3
pkgrel=1

_modname="nginx-${pkgname#nginx-mainline-mod-}"
_nginxver=1.19.0
pkgdesc="It is a NGINX module that provides dynamic linking to your application in server context and call the function of your application in location directive"
arch=('x86_64')
depends=('nginx-mainline')
url="https://github.com/Taymindis/nginx-link-function"
license=('BSD')

source=(
    https://nginx.org/download/nginx-$_nginxver.tar.gz{,.asc}
    $_modname-$pkgver.tar.gz::https://github.com/Taymindis/$_modname/archive/$pkgver.tar.gz
)


validpgpkeys=(
    'B0F4253373F8F6F510D42178520A9993A1C052F8' # Maxim Dounin <mdounin@mdounin.ru>
)

sha256sums=(
    '44a616171fcd7d7ad7c6af3e6f3ad0879b54db5a5d21be874cd458b5691e36c8'
    'SKIP'
    '0b74d94896709aba21036ed6f9dfd63c9efc5b9921ee5892d28a4b03bd9b09bd'
)

prepare() {
    cd "$srcdir"/$_modname-$pkgver
    sed 's@/usr/local@/usr@' -i config
}

build() {
    cd "$srcdir"/nginx-$_nginxver
    ./configure --with-compat --add-dynamic-module=../$_modname-$pkgver
    make modules
}

package() {
    install -Dm644 "$srcdir"/$_modname-$pkgver/LICENSE "$pkgdir"/usr/share/licenses/$pkgname/LICENSE
    install -Dm644 "$srcdir"/$_modname-$pkgver/src/ngx_link_func_module.h "$pkgdir"/usr/include/ngx_link_func_module.h

    cd "$srcdir"/$_nginxver/objs
    for mod in ngx_*.so; do
        install -Dm755 $mod "$pkgdir"/usr/lib/nginx/modules/$mod
    done
}```
Taymindis commented

This issue where it can't detect the header location. You need to install the file in your C header location first before configure.

nmdnm commented

the package must be built without root rights, installing the header requires root rights
I already solved the problem with the command CFLAGS="-I../nginx-link-function-3.2.3/src" ./configure --with-compat --add-dynamic-module=../nginx-link-function-3.2.3, for some reason the first time I tried it it didn’t work, now it works, thanks for the help