When no telium-settings.json is included, attempts to repeatedly load file are made with every track call

[iankerr]

If there is no tealium-settings.json file in the build, there is no point in trying to reload it every time a tracking call is made

Steps to reproduce:

1. In TealiumHelper, line 48, change to useRemoteLibrarySettings = false
2. Delete mobile\src\main\assets\tealium-settings.json
3. Run demo app, press the track button a few times.
4. Look in logcat, repeated entries are made:

2021-10-04 14:58:26.723 4175-4212/com.tealium.mobile I/Tealium-1.2.7: Asset not found (tealium-settings.json)
2021-10-04 14:58:27.152 4175-4212/com.tealium.mobile I/Tealium-1.2.7: Asset not found (tealium-settings.json)
2021-10-04 14:58:27.943 4175-4212/com.tealium.mobile I/Tealium-1.2.7: Asset not found (tealium-settings.json)

Suggested fix, LibrarySettingsManager.kt, line 82:

            false -> {
                val librarySettings = loadFromAsset(assetString)?.also {
                    Logger.dev(BuildConfig.TAG, "Loaded local library settings.")
                }
                isAssetSettingsLoaded = true
                librarySettings
            }

Looks like isAssetSettingsLoaded was only being set after a successful load. But this should probably be set even if unsuccessful, as the default settings will be used, and checking again will never be successful.

[jameskeith]

@iankerr - thanks for the detailed explanation.
We'll look at including that change in the next release

[jameskeith]

@iankerr - this has now been fixed in v1.2.8.