d.ts type definition error

Question

eczn opened this issue 5 years ago · 7 comments

⬆️ the type of t4.a should be a number type, not never.

Answer 1 · 2019-11-18T16:08:32.000Z

Answer 2 · 2019-11-19T08:41:05.000Z

What would be the correct way to fix the type definition? https://github.com/TehShrike/deepmerge/blob/master/index.d.ts#L1-L2

#181 here

Answer 3 · 2019-11-19T08:42:22.000Z

Answer 4 · 2020-02-03T15:08:58.000Z

@TehShrike any plans to merge the PR?

Answer 5 · 2020-10-17T19:03:23.000Z

Sorry for not looking in for a while – any other TS folks want to give #198 a review? @teppeis @RebeccaStevens @s-edlund

Answer 6 · 2020-10-17T21:38:11.000Z

I can probably give it a review a bit later today

Answer 7 · 2020-10-19T22:12:17.000Z

Sorry I took a bit longer to do this than I said I would but I just reviewed it. It's good but I found some issue with it; I've commented them there.