Pydantic project dependency not consistent (possibly others too; consider using a singe python packaging model?)
dotWee opened this issue · 1 comments
dotWee commented
Describe the bug
It is currently not possible to add fastapi-framework to projects using a different pydantic version.
Seems like @dependabot forgot to take care of the pyproject.toml, as it still references an outdated pydantic version.
fastapi-framework/pyproject.toml
Line 21 in 104202c
fastapi-framework/requirements.txt
Line 9 in 104202c
To Reproduce
$ poetry add fastapi-framework
Using version ^1.5.3.3 for fastapi-framework
Updating dependencies
Resolving dependencies... (0.1s)
Because fastapi-framework (1.5.3.3) depends on pydantic (1.10.5)
and no versions of fastapi-framework match >1.5.3.3,<2.0.0.0, fastapi-framework (>=1.5.3.3,<2.0.0.0) requires pydantic (1.10.5).
So, because ourpoetrypackage depends on both pydantic (^1.10.7) and fastapi-framework (^1.5.3.3), version solving failed.When trying to use the develop branch:
$ poetry add git+https://github.com/Tert0/fastapi-framework.git#develop
Updating dependencies
Resolving dependencies... (0.0s)
Because fastapi-framework (1.5.3.3) @ git+https://github.com/Tert0/fastapi-framework.git@develop depends on pydantic (1.10.5)
and ourpoetrypackage depends on pydantic (^1.10.7), fastapi-framework is forbidden.
So, because ourpoetrypackage depends on fastapi-framework (1.5.3.3) @ git+https://github.com/Tert0/fastapi-framework.git@develop, version solving failed.Expected behavior
Package fastapi-framework can be used together with latest Pydantic & FastAPI versions.
(Cheers & thank you for sharing your code! Your open source work is really appreciated!)