TeslaGov/ngx-http-auth-jwt-module

Publish source for build with current nginx?

lukepalmer opened this issue · 5 comments

lukepalmer commented

Hello- thanks for the great module!

I noticed that 2.0.2 does not build against current stable nginx, and that there was probably a breaking change due to nginx/nginx@3aef1d6.

I think this must be solved in code that isn't published, and also that this may be the reason for multiple binary assets being published along with the most recent release.

I do need to build from source for my usage. Would it be possible to publish these changes? Thank you!

JoshMcCullough commented

Current stable NGINX is 1.24.0 -- the module builds fine for that version, as well as the current mainline version (1.25.3).

Can you elaborate on the issue you're seeing?

JoshMcCullough commented

And yes, the headers changes were a breaking change but that was applied to the module's code long ago.

lukepalmer commented

Ah I see it now.
The Dockerfile sets a build flag to have this work:
BUILD_FLAGS="${BUILD_FLAGS} --with-cc-opt='-DNGX_LINKED_LIST_COOKIES=1'"

Because I am building from source and not using docker I need to set this myself. So if anything this is a very minor documentation issue.

Thanks for the quick response!

bugsmafia commented

for version nginx 1.25.4 - update pls

JoshMcCullough commented

@bugsmafia are you requesting we release binaries for NGINX v1.25.4? I built it just for you, you can find it here: https://github.com/TeslaGov/ngx-http-auth-jwt-module/releases/tag/2.0.3