Remove LGTM from PR process
mblayman opened this issue · 5 comments
With the advent of GitHub's PR review capability, I think that LGTM could be removed. As it stands, it's not currently working anyway. I've approved PRs and the service is not recognizing the approval even though I'm on the MAINTAINERS list. In those cases, I've had to override some angry looking warnings from the GitHub PR system.
I was wondering why the service wasn't working with the last few PRs and now I know why. The LGTM service shut down. It should definitely be disabled as it forces admin to override the PR process to merge something.
I deleted the webhook.
@jonathanKingston Do you mind looking into this? I deleted the webhook. For some reason, that change didn't seem to be enough to remove LGTM. Every time I merge on this project, I have to override a big warning message.
I'd love to be able to merge without this override. I'm wondering if there is something extra that you can see as the owner of this project.
Thanks!
Sorry for the delay here I removed the LGTM from the branch merging rules and required one approval review through github instead from someone who can merge, this can be removed as well but it's way less restrictive and easier to maintain.
Thanks, @jonathanKingston !