Textualize/trogon

Trogon doesn't work with Textual 0.54.0

daneah opened this issue · 4 comments

daneah commented

When using Textual 0.54.0, the right-side panel with the inputs for building up a command with arguments and options no longer loads.

Explicitly pinning to textual<0.54.0 returns things to working order.

Reproduction here

willmcgugan commented

@darrenburns One for you?

davep commented

Having a quick poke at this and I think I've narrowed it down to this:

#home-sidebar {
  dock: left;
  width: auto;
}

Seems the docked sidebar, now, is going full-width on the screen and pushing everything else out of the way. If you (as a test) set the width to 30, things start to look as they should again. Looks to be down to some difference in the way auto is being handled here.

davep commented

Looks to be a fight between a Label within the sidebar and the sidebar. If I change the above to something like:

#home-sidebar {
  dock: left;
  width: auto;

  & > Label {
      width: auto;
  }
}

it more or less all falls back into place (albeit with the label being more narrow than it would have been before).

Presumably the #home-sidebar doesn't have anything inside it that it can take a width clue from.

  • 👍1
davep commented

As a followup: Textualize/textual#4360 seems to be the root cause of this and the workaround added by the PR related to this can be undone if Textual reverts this behaviour.

  • 👍1