Stuff to improve on
MiniDigger opened this issue · 1 comments
MiniDigger commented
Hey there!
nice to see that you want to help ppl to learn to code!
There seem to be some things you can improve on:
- upload the full projects here, not only weird files without extentions
- don't use illegally distribute spigot jars, only legal way to get spigot is via buildtools
- don't use bungees chatcolor if you don't need to
- don't log that your plugin was enabled, bukkit does that
- don't log multi line via \n, breaks formatting
- use @OverRide if you override methods from a superclass (to avoid typos ;))
- explain what deprecated means and why it is bad to use those methods
- use name() on enums to convert it to a readable string
- encourage DRY (you copy pasted the event listener for block place)
- you can access server stuff using the Bukkit class
- don't extend CommandExecute if you want to make commands....
- you can save locations directly, no need to save every coordinate
advanced stuff:
- suggest other IDEs
- suggest a proper build system
keep up the great work!
The-SourceCode commented
Thank you.
- i only upload the files because there is no need to upload the whole project. They are learning the code, which can be seen from these very files.
- I just use that because most times it is much easier for people and have had no issues with that site. People can do it however they see fit but I think most people want the easiest way.
- Most times that is from an improper import.
- Some people like to see a nicely colored message, or a custom message when they launch their plugin.
- Using \n in log should not work anyway from what I remember. If it does I probably just used it for speed purposes.
- Not sure what methods other than onEnable/disable I have used that would call for an override
- Copy that
- Copy that
- Copy that
- True, but most times I just use the main class instance because I need to grab stuff from the main class.
- Copy that
- I usually save every cord because I do not want all the extra crap that goes along with it.