[OTHER] Inconsistent coding style with `.clang-format`
yaoyhu opened this issue · 10 comments
What would you like to share?
What is the actual coding style for Algorithms/C?
The online documentation suggests that this should be consistent with the CMU Style, which has been followed with CONTRIBUTION GUIDELINES.
However, it appears that the use of parentheses in all code within the repository does not conform to this CMU coding style.
Additional information
I wasted 30 min on this: I thought that there was an issue with my VS Code settings or with Clang-Format, but I later realized that the problem was with the inconsistency between the .clang-format file and the coding standards.
Those coding guidelines are very old now (5+ years).
We probably should either remove it or update them.
Those coding guidelines are very old now (5+ years).
We probably should either remove it or update them.
I think the coding style of CMU is very good, and LLVM and Google both use this type of formatting for their parentheses. Therefore, I think it's better to reformat the code in the repository.
Sounds good to me. 👍
We should wait for the input of other maintainers, though.
This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Please ping one of the maintainers once you add more information and updates here. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!
Those coding guidelines are very old now (5+ years).
We probably should either remove it or update them.I think the coding style of CMU is very good, and LLVM and Google both use this type of formatting for their parentheses. Therefore, I think it's better to reformat the code in the repository.
CMU sounds good
This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
I've modified the `.clang-format' within my PR #1283, which satisfies the CMU coding standard.
This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Please ping one of the maintainers once you add more information and updates here. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!