Does the LGTM tool ever find any issues that are useful to fix???
cclauss opened this issue · 14 comments
For Python, the LGTM tool is nearly useless so we got rid of it. Is the same true for Go?
Personally, I haven't seen it do anything at all
LGTM usually checks for syntax errors and things like unused variables, but those are builtin into the go compiler.
LGTM for Go is also quite useless. Go build tools are usually able to give users all warnings when compiling. Plus all of the warnings LGTM gives are also picked up by golangci-lint tool. So, I think its redundant for Go repos and can be removed in this repo too. In my opinion, there is another tool called goreportcard link to this repos report card which is much more useful for picking out things that are not well written - the only caveat is that it doesn't give users the warnings on PR's.
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
Should we get rid of it? I don't think LGTM is useful at all for us - in fact, it slows down the workflows passing.
I think we should get rid of it.
@siriak Do you have permission to remove the LGTM analysis from this repo? If so, could you remove it?
I don't have, this this needs to be done via their website
@cclauss I think it depends on what else does the Go repository have. If there are enough checks, I think it makes perfect sense to deprecate it. I assume @dynamitechetan or the owners should have rights to disable it?
If there are enough checks
https://github.com/TheAlgorithms/Go/tree/master/.github/workflows seems to provide appropriate and fast test coverage.
If there are enough checks
https://github.com/TheAlgorithms/Go/tree/master/.github/workflows seems to provide appropriate and fast test coverage.
I believe so. I think any maintainers can disable it on their website then. cc @AnupKumarPanwar
Maintainers can't do that unfortunately - only admins can. cc @siriak
I have turned it off