[Sf4] Stop using ContainerAwareCommands

Question

[Sf4] Stop using ContainerAwareCommands

althaus opened this issue 6 years ago · 8 comments

Hi,

due to changes in Symfony the commands shouldn't access the container directly, but use service injection instead:

The "Tbbc\MoneyBundle\Command\RatioFetchCommand" class extends "Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand" that is deprecated since Symfony 4.2, use {@see Command} instead.

The "Tbbc\MoneyBundle\Command\RatioListCommand" class extends "Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand" that is deprecated since Symfony 4.2, use {@see Command} instead.

The "Tbbc\MoneyBundle\Command\RatioSaveCommand" class extends "Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand" that is deprecated since Symfony 4.2, use {@see Command} instead.

Cheers
Matthias

Answer 1 · 2019-07-26T09:04:02.000Z

Fixed in #110
If it gets accepted and merged

Answer 2 · 2019-12-12T11:34:06.000Z

I don't think this bundle is being managed anymore. @philippe-levan

Answer 3 · 2019-12-12T13:16:52.000Z

I've switched to my own fork to get it running with Sf4/5. :/

Answer 4 · 2019-12-16T13:46:31.000Z

Can you share your package with everyone so we can start using your bundle? I think you can register your fork on packagist?

Answer 5 · 2020-01-14T07:28:22.000Z

Thanks for all your contributions guys, sorry I only could only check this now.
It would be great to start checking Symfony 5 release, any PRs would be appreciated (and checked quickly!).

Answer 6 · 2020-01-14T08:28:13.000Z

I made some updates in my fork (https://github.com/althaus/TbbcMoneyBundle/releases), but didn't check for BC as I just needed to get it working again.

Answer 7 · 2020-01-15T07:09:04.000Z

Yes, I saw your fork, making something along same lines. I plan major release so support for some older php and symfony versions will also be dropped.

Answer 8 · 2020-04-12T12:08:30.000Z

This is done and released