TheKingEagle/RMSoftware.ModularBot

External Module Commands "success" but no execution [Startup.core]

TheKingEagle opened this issue · 1 comments

Summary
Any module command loaded from modules folder will fail to execute in startup.core

To Reproduce

  1. Ensure TestModule is in modules folder
  2. Open startup.core
  3. insert a command from module that also has a service dependency (CMD polljoin <your guildID> <your channel id>)
  4. save then restart bot.
  5. Notice a success message in console but no actual command is performed.

Expected behavior
Command debug messages and actions are executed as requested.

Resolution
After adding a FirstChanceException handler, it was noted that the requested dependency was not found, and the module could not be loaded. This was caused by calling module loader after CustomCommandManager (thus including CoreScript) was already fed with a previously built service provider.

Fixed with Commit 064d04a & 64e14bf. This issue is to serve as a summary of changes for said commits.