TheOdinProject/javascript-exercises

Bug - Exercises : Test expecting wrong result & typo found

Closed this issue · 0 comments

Complete the following REQUIRED checkboxes:

  • [x ] I have thoroughly read and understand The Odin Project Contributing Guide
  • [x ] The title of this issue follows the Bug - location of bug: brief description of bug format, e.g. Bug - Exercises: File type incorrect for all test files

The following checkbox is OPTIONAL:

  • [ x] I would like to be assigned this issue to work on it

1. Description of the Bug:

Within exercise 12 (./12_findTheOldest/findTheOldest.spec.js), the second test states, "finds the oldest person if someone is still living"
The expected result is, "Ray". But Ray's yearOfDeath is: 2011. Meaning the test should expect, "Carly", because Carly is the only person without a yearOfDeath stated, making Carly the "oldest person if someone is still living" as stated in the test requirements.

Additionally, the third test data set states Carly's yearOfBirth to be 1066, when it should read as 2018.

2. How To Reproduce:

  1. Navigate to exercise 12, file: findTheOldest.spec.js
  2. line 41 shows the incorrect expected result as 'Ray'
  3. line 47 shows the yearOfBirth typo

3. Expected Behavior:

  1. line 41 should state 'Carly' as the expected result
  2. line 47 should reflect yearOfBirth as 2018, and not 1066

4. Desktop/Device:

N/A

5. Additional Information:

This is my first bug report on Github and I believe I met all the required criteria. I apologize in advance if I mistakenly overlooked anything. I assure you it was not intended.

Thank you!