TheOdinProject/javascript-exercises

Bug - in the authentication basics at the bcrypt.hash function the first argument says "somePassword" which makes it seem like its for a string to name the hash or something when instead it should say req.body.password as that is how the tutorials index.ejs forms password input is setup with name passord :

Closed this issue · 3 comments

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this issue follows the Bug - location of bug: brief description of bug format, e.g. Bug - Exercises: File type incorrect for all test files

The following checkbox is OPTIONAL:

  • I would like to be assigned this issue to work on it

1. Description of the Bug:

in the authentication basics at the bcrypt.hash function the first argument says "somePassword" which makes it seem like its for a string to name the hash or something when instead it should say req.body.password as that is how the tutorials index.ejs forms password input is setup with name passord

2. How To Reproduce:

3. Expected Behavior:

4. Desktop/Device:

  • Device: Ubuntu VM
  • OS: Linux
  • Browser: Chrome
  • Version:

5. Additional Information:
its confusing as it doesnt say to replace "somePassword" with req.body.password or to replace it at all it just says to add that function in

Looks like this should be addressed if #26202 from the curriculum repo is merged.

should be fixed!