ThePaulMcBride/react-native-smart-picker

`label` prop doesn't accept an object type.

Closed this issue · 10 comments

fxalvarezd commented

Hello,
We are using your component in our project, but need to style the label to match our design.
We did the following:

label={isIOS && selectedOption ? <Text style={styles.iosLabel}>{selectedOption.label}</Text> : ''}

but it requires to extend the propType validation to:

label: PropTypes.oneOfType([PropTypes.string, PropTypes.object]),

to avoid a console error.

Same thing needs to be done for readt-native-togglebox.

Thanks!

ThePaulMcBride commented

Makes sense to me! Would you like to submit a pull request?

fxalvarezd commented

Sure thing! I wasn't able to push my local branch remotely, probably need to enable some settings in your repos?

ThePaulMcBride commented
fxalvarezd commented

I just posted both PRs, thx!

fxalvarezd commented

Hey, was just wondering if you had some time to review the PRs? Thx!

ThePaulMcBride commented

Closed by #5

fxalvarezd commented

Thank you!

fxalvarezd commented

I think you need to update the react-native-togglebox dependency to 1.0.3?
https://github.com/ThePaulMcBride/react-native-smart-picker/blob/master/package.json#L22

ThePaulMcBride commented

👍 I'll do this now. I'm an idiot!

fxalvarezd commented

😉 Thanks!