TheThingsNetwork/lorawan-stack

Propagate EndDeviceIDs for various interfaces in AS

KrishnaIyer opened this issue · 0 comments

KrishnaIyer commented

Summary

Propogate EndDeviceIDs for various interfaces in AS. Refs: #4890 (comment)

Why do we need this?

Convenience I guess?

What is already there? What do you see now?

With #4890, we refactor to remove the embedded options.

What is missing? What do you want to see?

Change the func signatures of the following interfaces to accept *ttnpb.EndDeviceIdentifiers

  • as.getLink
  • as.handleJoinAccept
  • s.skipPayloadCrypto
  • registerPackageFail
  • p.sendDownlink
  • p.sendQuery
  • w.registry.List
  • withDeviceID (webhooks)

Environment

v3.16.0

How do you propose to implement this?

Change interfaces, update usage and tests.

How do you propose to test this?

UT

Can you do this yourself and submit a Pull Request?

Yes