[Feature Request]: increase ADSR max values and allow slower LFOs
Opened this issue · 3 comments
The goal of my feature request is to make OdinII a bit more Waldorf-like, with longer envelope times and slower modulation potential via LFO / envelope.
I would like to see max values for ADSR attack, decay, and release increased from 10 seconds to 30 seconds. I would like to see LFO minimum speed reduced for 0.5Hz to 0.1Hz.
While I am not any sort of C++ coder, I have established that at least a portion of the changes involve changing the ranges in AudioValueTree.h. I kind of doubt the solution is that simple, but I'm open to helping with a little guidance!
Hi @elektronen
You are right in your assesment: Just change the values as you like in AudioValueTree.h and compile the synth. It will have the updated limits and I don't think there will be an issue in the DSP code either.
The bigger problem with updating parameter ranges is that presets and plugin states aren't loaded as the values on display, but rather a value between 0 and 1, which is then remapped onto the original value. By changing the mapping, any loaded preset will contain wrong values, i.e. what was 0.05Hz will then be 0.01Hz. This can be circumvented by introducing another layer of translation when loading the patch, but I am unlikely to invest the time anytime soon, sorry.
For what it's worth, you can adjust the params yourself and enjoy your selfmade custom version of Odin 2. This is one of the benefits open source is all about after all :) If you need any further help I'm happy to assist.
Hi. Thanks for the helpful confirmation. I enjoy making all my own patches, so won't be too distressed about the presets!
I forked the odin2 repo, and after a rather clumsy accidental pull request, I made the changes and successfully compiled under XCode 10 on macOS 10.13.6.
I'd like to make some contributions, right now just a cosmetic one of a newer screenshot for the README. I will create a new branch in my fork just for that, then submit a new pull request.
It's possible I can work on tweaking the presets, too. I'll see how that goes.