TheWidlarzGroup/react-native-notificated

Drop react-native-device-info for react-native-safe-area-context[FEATURE]

Closed this issue · 0 comments

Is your feature request related to a problem? Please describe.
I am trying out the library with expo since it says support expo>=41, but react-native-device-info is not supported by expo which makes this library not accessible for expo user unless using a custom development client.

It is prevents most expo users from using this library, me being one of them, especially since you are only using hasNotch method.

Describe the solution you'd like
Use react-native-safe-area-context for the following reasons:

  • supported by expo
  • it gives you the exact notch height instead of whether there is a notch or not and setting a random value of 50 for the notch height as I can see in the source code

Describe alternatives you've considered
Use a custom development client to install react-native-device-info, but it is really not worth it the work into it