highres fix doesn't work with sdxl
magicbot42 opened this issue · 8 comments
Hi again,
Just playing around with sdxl dreamshaper from civitai and noticed that with only umprompted enabled, highres fix errors out with these sdxl models. This is with the latest 1.5.1 version of automatic1111. Was suprised that unprompted already worked with sdxl otherwise though.
Cheers!
Was suprised that unprompted already worked with sdxl otherwise though.
Me too... :-)
I'm taking a look at the issue now and will try to have a fix out soon.
Hmm, I'm actually not seeing any errors using hr fix with the model you mentioned. I'm trying with "dreamshaperXL09Alpha_alpha2Xl10.safetensors [0f1b80cfe8]."
Can you share your console log with me? It might also be helpful to know what your hr fix settings are - I tested Latent upscaler with 0.5 denoising and 1.5x upscale.
Thanks!
So the Traceback only seems to occur when reading the prompt from within a file. Here i've put a simple prompt in x/test.txt and negative prompt in x/test_negative.txt. The prompt/negative prompt work with hires fix when outside of the files and without the file shortcode calling them, but once inside the files and calling them with the file shortcode I get this traceback:
These are my current versions, plus umprompted is the latest version. only unprompted enabled:
Maybe this is a similar error to the other one recently seen with hires fix?
Also, forgot to mention, here I used the same settings with Latent upscaler as you used .5 denoise, and 1.5 scale. It seems to be the call to the file shortcode causing hires fix to tracback like this.
Actually after playing around, I'm not sure I know what's going on here. It seems somewhat intermittent. Not always caused by hires fix being on, but easier for it to happen with it on. It doesn't happen with unprompted turned off. Quick google and it seems other extensions are causing this too with sdxl:
AUTOMATIC1111/stable-diffusion-webui#12038
and here in the comments:
AUTOMATIC1111/stable-diffusion-webui#11757
Update ControlNets extension, it should be fixed now. Update or disable any other extensions that hook in to gen.
It turns out that hires pass with SDXL models refer to hr_prompts instead of all_hr_prompts... I'm not sure if the latter is deprecated everywhere, or just for SDXL. Either way, I'll have a fix for you out momentarily.
Fix is out. Please let me know if hires fix still gives you any trouble.