BST Pet Ready move "Wild Carrot" doesn't seem to trigger a GetPetAction()
dwardlow opened this issue · 4 comments
The high level Rabbit Jugpets (Lucky Lulush / Droopy Dortwin / Pondering Peter etc) have an AoE HP Restoration move called "Wild Carrot" which scales in potency based on the Pet's Current TP.
The initial trigger for this Ready move seems to be picking up in LuAshitaCast as a PlayerAction just fine... so any Precast gear changes (Desultor Tassets etc) work perfectly. However whenever the Pet actually gets around to using the associated move a second or two later, it doesn't appear to be triggering any PetActions... which means that Midcast gear changes (Nukumi Manoplas +1 etc) aren't able to kick in.
As an illustration: the below abridged LUA profile only throws the string "Wild Carrot" into the chatlog once (on player action activation)... but for other Ready moves it throws their ability name into the chat log at least twice (once on player action activation and then again during pet action activation).
profile.HandleDefault = function()
local petAction = gData.GetPetAction();
if (petAction ~= nil) then
gFunc.Error(petAction.Name);
end
end
profile.HandleAbility = function()
local playerAction = gData.GetAction();
gFunc.Message(playerAction.Name);
end
(Thanks for your work on this BTW, was nice to find an equipment swapping addon which works with Ashita v4!) :)
Are you able to confirm whether this issue is on retail, private servers, or both?
Retail (Ragnarok server) is where I've been using this addon + seeing the above issue. (The only private server I have is a heavily customised Darkstar ToAA fork from ~5 years back which is probably not a great test case; and IIRC doesn't have many Jugpets beyond the Lv75 era implemented anyway!)
It seems to be only affecting the Rabbit's "Wild Carrot" for some odd reason. Dhalmel's "Healing Breeze" (a very similar AoE heal) and other "buffs" and "attacks" appear to all be working fine.
Example screenshot 1 (READY - PonderingPeter JugPet's Wild Carrot)
Example screenshot 2 (SIC - Dhalmel Charmed Pet's Healing Breeze - with the expected RED ERROR TEXT and gearswap into Nukumi Manoplas successfully kicking in for MidCast)
Example screenshot 3 (READY - PonderingPeter regular damaging attack "Foot Kick" - with the expected RED ERROR TEXT and gearswap into Nukumi Manoplas successfully kicking in for MidCast)
Example screenshot 4 (SIC - Dhalmel pet's non-damaging buff "Berserk" - with the expected RED ERROR TEXT and gearswap into Nukumi Manoplas successfully kicking in for MidCast)
That should be sufficient data to reproduce and solve this issue. I'll grab some jugs tomorrow and take a look.
After looking into this, it appears that Wild Carrot is effectively instant. The packets for readying and completing arrive in the same communication on retail, meaning that by the time you have a chance to react to it the HP is already gained. You can actually see this in real time, the pet's HP increases instantly as soon as the ready message appears.
LAC is correctly detecting the ability's start, but also registering the finish immediately after, so no HandleDefault occurs while the ability is pending. There is no solution here that will allow precast and midcast, you will have to decide in the ability section if you want the Nukumi Manoplas.