ThornyFFXI/LuAshitacast

Feature Request: gData.GetPlayer().GetBuffs()

Closed this issue · 2 comments

Seems odd we can use gData.GetBuffCount() to see the amount of buffs on us, but can't know what buffs we have without digging into AshitaCore:GetMemoryManager():GetPlayer():GetBuffs() from within our job luas. Inconvenient for making, e.g. THF Sneak Attack/Trick Attack sets work. Maybe I'm missing something though?

Feel like the best option would be to grant access through the player table provided by gData.GetPlayer(). Should be a really simple PR if you'd like one.

I completely misread what GetBuffCount was doing. I understand now, we can access our buffs through that.

Leaving this open because I still think this would be more intuitive access to the list though.

Might actually amend this to just requesting a boolean buff check actually. GetBuffCount makes a lot of sense for stacking buffs (e.g. steps, shadows) but a proper boolean return is more useful in most instances.

Eh whatever, closing. Will remake when I've thought it through some more.