ThorstenHans/ngx-electron

The package doesn't seem to work with Angular 6

Closed this issue · 9 comments

shailesh1729 commented

I was trying to build an electron-angular application. After installing the package via npm, adding it to dependencies, and then importing it in app.module.ts, here is the error I am getting:
ERROR in node_modules/ngx-electron/src/electronService.d.ts(1,27): error TS2307: Cannot find module 'electron'. node_modules/ngx-electron/src/electronService.d.ts(16,23): error TS2503: Cannot find namespace 'NodeJS'.

Not sure what to do now.

TheYojimbo commented

Hi @shailesh1729, we've encountered the "Cannot find namespace 'NodeJS'" as well, and we fixed it by adding "types": ["node"] in our tsconfig.app.json as explained here : https://github.com/TypeStrong/typedoc/issues/320.
We didn't have the other issue with electron, but we hope this helps !

jvaes commented

@shailesh1729 I fixed this by adding "electron" to my project.

npm install electron --save-dev

Hope this helps!

  • 👍2
  • 🎉1
dariusll commented

image

  1. Created new Angular 6 project using Angular cli.
  2. npm install electron --save-dev
  3. npm install ngx-electron --save
  4. Imported ngx-electron inside app module
  5. launching this._electronService.shell.openExternal('https://google.com') inside app.component.ts
ThorstenHans commented

currently working on a re-write for latest Angular..

should be out by the end of the week.

ofirmgr commented

any news? I can't upgrade to angular 7

euberdeveloper commented

I installed electron with --save-dev option, I imported ngx-electron correctly but it does not work with ng serve. I mean, if I build the angular 6 app, and run electron . it works well, but while I am developing the app and I don't want to compile the app to see the result it does not work. remote and almost every property in the service is set to null. Is it normal?

ThorstenHans commented

should be fixed with the most recent release 2.0.0

elcordova commented

need add BrowserModule with NgxElectronModule in imports

vieillecam commented

Not sure I understand why we have to include the 'electron' package inside our WebApp in order to be packaged in... Electron... For me, it has been resolved only by adding the electron types to the dev dependencies.: npm install -D @types/electron

  • 👍1