ThreeTen/threeten-extra

Add OffsetDate

Closed this issue · 6 comments

After adding support for ThreeTen-Extra in threeten-jaxb/threeten-jaxb I want to tackle better compatibility with the XML schema definitions, especially xs:date.

You already explained, why OffsetDate even exists in a Stack Overflow answer.

I found that OffsetDate was removed from ThreeTen, because there are only few use cases: ThreeTen/threeten#228

Others are reimplementing OffsetDate on their own, like Addicticks/jaxbdatetime, but I think, it might be better to have it in ThreeTen-Extra. What are your thoughts on this?

I think this would make a good addition to ThreeTen-Extra.

Great to hear!

What are the steps to achieve this? Is it possible to use the implementation once removed from ThreeTen? Should I provide a PR or would that be more of a hinderance?

If you'd like to dig out the one from ThreeTenBP history that would be a good start. I'll probably end up adding to it, but if you could create the branch with the class and test that would be a good start.

Okay. When I find time, I'll try to get most of what was removed with ThreeTen/threetenbp@d9ad1de to work in ThreeTen-Extra.

I started working on this and I created a PR to make it easier to talk about it: #138

Fixed by #138