Dangerous type piracy

Question

Dangerous type piracy

Opened this issue 9 months ago · 4 comments

https://github.com/ThummeTo/FMISensitivity.jl/blob/main/src/FMISensitivity.jl#L40-L42 that's not great.

Answer 1 · 2023-10-07T10:13:31.000Z

Yep, you got me :)
Is there a reason why increment_deriv! is not defined for a ZeroTangent-increase?
In my head incrementing a TrackedReal by ZeroTangent shoud be defined, but just be a no-op.

If not, I need to dig deeper and prevent this call from happening...

Answer 2 · 2023-10-07T11:02:05.000Z

If this is needed then upstream it?

ZeroTangent though is from ChainRules.jl, which ReverseDiff doesn't integrate with. This seems like however you did some chainrules thing forgot to handle this case.

Answer 3 · 2023-10-08T13:29:16.000Z

you are right, I will check for that... maybe the @grad_from_chainrules macro

Answer 4 · 2023-10-08T13:33:10.000Z

you are right, I will check for that... maybe the @grad_from_chainrules macro