Thyraz/Sonos-Kids-Controller

Error on npm install (jasmine module missing?)

stepman0 opened this issue · 5 comments

stepman0 commented

I just updated to the latest commits and wanted to build my container images.

I get an error message regarding a missing npm package:

=> ERROR [stage-1 4/6] RUN npm install --production                                                                                                                                                      3.8s
------
 > [stage-1 4/6] RUN npm install --production:
#9 3.784 npm notice
#9 3.785 npm notice New minor version of npm available! 7.7.6 -> 7.12.1
#9 3.785 npm notice Changelog: <https://github.com/npm/cli/releases/tag/v7.12.1>
#9 3.785 npm notice Run `npm install -g npm@7.12.1` to update!
#9 3.785 npm notice
#9 3.789 npm ERR! code ERESOLVE
#9 3.793 npm ERR! ERESOLVE unable to resolve dependency tree
#9 3.793 npm ERR!
#9 3.793 npm ERR! While resolving: sonos-kids-controller@1.1.0
#9 3.794 npm ERR! Found: jasmine-core@3.5.0
#9 3.794 npm ERR! node_modules/jasmine-core
#9 3.794 npm ERR!   dev jasmine-core@"~3.5.0" from the root project
#9 3.794 npm ERR!
#9 3.794 npm ERR! Could not resolve dependency:
#9 3.794 npm ERR! peer jasmine-core@">=3.7.1" from karma-jasmine-html-reporter@1.6.0
#9 3.794 npm ERR! node_modules/karma-jasmine-html-reporter
#9 3.795 npm ERR!   dev karma-jasmine-html-reporter@"^1.4.2" from the root project
#9 3.795 npm ERR!
#9 3.795 npm ERR! Fix the upstream dependency conflict, or retry
#9 3.795 npm ERR! this command with --force, or --legacy-peer-deps
#9 3.795 npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
#9 3.795 npm ERR!
#9 3.795 npm ERR! See /root/.npm/eresolve-report.txt for a full report.
#9 3.805
#9 3.805 npm ERR! A complete log of this run can be found in:
#9 3.805 npm ERR!     /root/.npm/_logs/2021-05-11T12_17_10_260Z-debug.log
------
executor failed running [/bin/sh -c npm install --production]: exit code: 1

I tried both with node-15 and node-16.

I have no real knowledge about npm - Any hints?

stepman0 commented

I just found something similar on stackoverflow.

stepman0 commented

According to the stackoverflow post, I changed the following versions in package.json:

"@types/jasmine": "~3.7.1", (from 3.5.0)
"jasmine-core": "~3.7.1", (from 3.5.0)

Now the containers build again. I cannot test at the moment, my kids are using their "music tablets" ;-)

@Thyraz: Can you please confirm, that I do not break anything else? Then I can create a pull request.

Thyraz commented

Just noticed the same here, as I finally had some time to merge some Pull Requests.
Did some quick tests and everything seems to be fine.

So feel free to create Pull Request.

Thyraz commented

Ah sorry, it's already in my last commit.
I updated the version of Sonos-Kids-Controller and the new jasmine versions are in the same file...

stepman0 commented

👍🏻