TiddlyWiki/TiddlyWikiClassic

Fix favicon

Opened this issue · 4 comments

markkerrigan commented

It looks like for whatever reason, MarkupPreHead isn't making it into the built versions of classic.tiddlywiki.com

Also it's unsure if the favicon.ico tid is needed as this ends up generating links to nonexisting tiddlers.

It might also be a good idea to write a quick description about how to add a favicon.

YakovL commented

Hello Mark, thanks for pointing, I've included the first 2 issues into the plan of 2.10.1 (see #299).

As for the last part, let me start from a short draft here:

  • the main way to set favicon is to add something like <link rel="shortcut icon" href="images/favicon.ico" /> into MarkupPreHead, save TW and reload;
  • the images/favicon.ico bit is the relative path to the favicon, for the case when it's a separate file;
  • there are 2 alternatives to using a separate file:
    • using base64 and
    • using an SVG (to check: can it be used without being packed into base64).

Todo:

  • explain how to generate base64 from an image and how to use it for favicon;
  • explain how to use SVG.
YakovL commented

Alright, [[favicon.ico]] is removed (0dac50d); indeed,

MarkupPreHead isn't making it into the built versions of classic.tiddlywiki.com

is correct, the current build procedure ignores those bits (markup blocks, page title, etc). I'll take a closer look later. For now, I've just manually fixed the favicon on the site by an additional commit (TiddlyWiki/tiddlywiki.github.com@5a8384c).

markkerrigan commented

OK great looks good right now.

YakovL commented

Yes, I've fixed it manually again during updating, but to fix it consistently, the build process should be updated, presumably by adding Puppeteer or Playwright to the workflow.

As for the description of using favicon, we should document it on the site and maybe provide a friendly UI for that later.