TypeError: Cannot read property '4' of null

Question

TypeError: Cannot read property '4' of null

dinaAlsaid opened this issue 4 years ago · 28 comments

    async function getPlaylistHandler(req, res) {
    const playlist = await ytpl(req.body.playlist);

  at Object.<anonymous>.exports.getGeneralInfo (node_modules/ytpl/lib/util.js:39:31)
  at Object.<anonymous>.module.exports (node_modules/ytpl/lib/firstpage.js:29:25)
  at Object.<anonymous>.module.exports (node_modules/ytpl/lib/main.js:13:20)
  at getPlaylistHandler (lib/server.js:56:20)

version installed: 1.0.1

Answer 1 · 2020-11-09T23:02:11.000Z

I can confirm that this issue is happening to me too

Answer 2 · 2020-11-09T23:05:13.000Z

Error stack: https://cdn.discordapp.com/attachments/775100233893806101/775493041926045756/unknown.png

Answer 3 · 2020-11-09T23:42:34.000Z

i have been getting the same

(node:3956) UnhandledPromiseRejectionWarning: TypeError: Cannot read property '4' of null
at Object.exports.getGeneralInfo (C:\Users\Galactica\Desktop\ytpl\YOUTUBE CODE\node_modules\ytpl\lib\util.js:39:31)
at module.exports (C:\Users\Galactica\Desktop\ytpl\YOUTUBE CODE\node_modules\ytpl\lib\firstpage.js:29:25)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
at async module.exports (C:\Users\Galactica\Desktop\ytpl\YOUTUBE CODE\node_modules\ytpl\lib\main.js:13:20)
(node:3956) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:3956) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Answer 4 · 2020-11-10T00:08:11.000Z

Ya this happened to me too. Pretty weird how it worked just several hours ago but now it is giving errors.

Answer 5 · 2020-11-10T07:58:51.000Z

🤔 looks like we're in for the same changes as ytsr

Answer 6 · 2020-11-10T20:29:13.000Z

I had a quick look. The regex is failing. Seems like the HTML has changed. The initial error started with authorMatch and then fails at the playlist as well.

Answer 7 · 2020-11-11T20:07:45.000Z

Any idea of when a fix is going to happen?

Answer 8 · 2020-11-12T23:23:56.000Z

I'm going to investigate it tomorrow, and hopefully find a fix that works for me. If I'm finding one, I'm going to open a PR.

Answer 9 · 2020-11-13T23:18:52.000Z

The response body from youtube has dramatically changed. It seems that now it returns a sort of javascript object where most of the data can be retrieved. I've included a dump of that object that I got from firstpage.js at line 14.
In utils.js most of the data is retrieved via regular expressions. I think that browsing and retrieving data from the object is way more convenient and most of the utils.js file should be rewritten, at this point.
I'm taking a break for tonight, I'll keep you updated during the weekend as I work further on the issue.
If someone wants to continue from where I got, please ping me here so none of us will waste time ;)
I attached a zip file containing the object I got.
Thank you.
ytdata.js.zip

Answer 10 · 2020-11-14T23:01:13.000Z

I've almost finished fixing the function getGeneralInfo in /lib/utils.js.
I think that I will be able to finish it, and probably the other functions as well by tomorrow.
I'm heading to bed! ;)

Answer 11 · 2020-11-15T22:36:22.000Z

I uploaded my fix, I don't know if it will be merged, but feel free to use it while waiting for an official merge or improvement. You can find it in the pull requests.

Answer 12 · 2020-11-16T02:52:43.000Z

I uploaded my fix, I don't know if it will be merged, but feel free to use it while waiting for an official merge or improvement. You can find it in the pull requests.

Thanks heaps!
How do you install specific branches?

Answer 13 · 2020-11-16T04:44:52.000Z

Doesn't seem to be working even after updating that file

Answer 14 · 2020-11-16T05:14:18.000Z

I've a couple ideas why it's not working. Please send me the playlists you are using, so I can understand why it happens

Answer 15 · 2020-11-16T05:28:24.000Z

I updated the util.js file to what you made it unless I did something wrong?
But here is the playlist link I tried: https://www.youtube.com/playlist?list=PLMC9KNkIncKtPzgY-5rmhvj7fax8fdxoj

Answer 16 · 2020-11-16T09:41:32.000Z

@dbrn check my comments in the pull request if you want more playlist not working. i got a error with json.parse and another one with string.replace(/\n\r?/g, ' ')

thanks

Answer 17 · 2020-11-16T21:32:36.000Z

@dbrn check my comments in the pull request if you want more playlist not working. i got a error with json.parse and another one with string.replace(/\n\r?/g, ' ')

thanks

I'm giving it a look just now :)

Answer 18 · 2020-11-16T22:02:26.000Z

Thank you everybody for your feedback and links!.
I added a new commit. Check the latest one, where I took your URLs as examples and did my best to fix the bugs that arose.

Answer 19 · 2020-11-18T16:25:01.000Z

This repo is very slow and inactive. Just use youtube-dl or YouTube's data API which can fetch playlist details easily

Answer 20 · 2020-11-18T21:24:40.000Z

This repo is very slow and inactive. Just use youtube-dl or YouTube's data API which can fetch playlist details easily

Some people would have to rewrite their code to switch libraries. Finding a way to make it work again could be an easier solution.

Answer 21 · 2020-11-19T04:05:42.000Z

This repo is very slow and inactive. Just use youtube-dl or YouTube's data API which can fetch playlist details easily

Some people would have to rewrite their code to switch libraries. Finding a way to make it work again could be an easier solution.

This repo is very slow and inactive. Just use youtube-dl or YouTube's data API which can fetch playlist details easily

Also, I much prefer the promise based coding format of this library rather than the event listening based format of something like youtube-dl.

Answer 22 · 2020-11-19T04:49:18.000Z

Some people would have to rewrite their code to switch libraries. Finding a way to make it work again could be an easier solution.

Also, I much prefer the promise based coding format of this library rather than the event listening based format of something like youtube-dl.

I agree with you, but if it takes such a long time to update this library every time it breaks, it's time to consider switching to a more reliable library.

Secondly, take a look into YouTube's data API and see if it fits your needs. I switched to it after ytpl broke and I'm finding it to be very fast and more reliable. Plus it has a quota of 10,000 free requests per day which is more than enough in most cases.

Answer 23 · 2020-11-19T10:00:56.000Z

This repo is very slow and inactive. Just use youtube-dl or YouTube's data API which can fetch playlist details easily

I always recommend the official api but it doesn't fit everyone's needs

I agree with you, but if it takes such a long time to update this library every time it breaks, it's time to consider switching to a more reliable library.

Gotta defend myself.
Most times the Problem is YouTube using rolling releases which means that just few people experience the problem and i am unable to recreate them.
This time it's just covid & working in IT that's keeping me way 2 busy.

Answer 24 · 2020-11-19T20:45:38.000Z

This repo is very slow and inactive. Just use youtube-dl or YouTube's data API which can fetch playlist details easily

I always recommend the official api but it doesn't fit everyone's needs

I agree with you, but if it takes such a long time to update this library every time it breaks, it's time to consider switching to a more reliable library.

Gotta defend myself.
Most times the Problem is YouTube using rolling releases which means that just few people experience the problem and i am unable to recreate them.
This time it's just covid & working in IT that's keeping me way 2 busy.

Fair enough. Hope you're doing well. Tbh I don't mind waiting. I much much prefer your libraries because of the promise based coding. Also because it's fully anonymous youtube downloader.
Also, it is nice to see that you are alive and well and not another creator of an npm library that lets it gather dust for years.

Answer 25 · 2020-11-27T11:37:18.000Z

@dbrn where's your code? I don't see a PR

@TimeForANinja I think we could apply evolutionary algos to traversing a parsed HTML or a bunch of parsing rules and run them on known playlists with expected output. I don;t really know how this library works exactly - the magic of using a library instead of rolling your own ;)
Do you think it could work?

Answer 26 · 2020-11-27T15:25:26.000Z

evolutionary algos to traversing a parsed HTML

no idea if it work's but just throwing ML at everything would crush efficiency

Answer 27 · 2020-11-27T15:44:17.000Z

@dbrn where's your code? I don't see a PR

it was merged in a secondary branch to do some more work, you can find it in the closed pull request. #88

Answer 28 · 2020-11-27T18:28:24.000Z

I meant to produce patches with them, not to use them in runtime.

I took a look at the page source of a playlist and got another idea - to make a fuzzy search on paths in json.
I got to a point of being able to fuzzy search paths pointing to string values. Need more work before I can get an array of items that way.

[edit]
got the first demo of fuzzy searching for an object
https://github.com/naugtur/fluffy-eureka