TinasheMzondiwa/cis-hymnals

French hymns

Burkifa23 opened this issue · 17 comments

Burkifa23 commented

Describe the new language you'd like
Greetings everyone,
I hope you are all doing well.
I am planning to add on the 2 French hymns. Already in progress..
There is Donnez-Lui Gloire with 520 hymn songs.
Then Hymnes et Louanges with 654 hymn songs.

Source files
Both of the files can be found at toisanges.org which is a French SDA resourceful website.
Donnez-Lui Gloire
Hymnes et Louanges

Additional context
To make neat-looking paragraphs, we should add "\n" to all the other hymns after punctuation in order to control how the paragraphs look. For example, all the hymns' paragraphs should look like the Christ In Song. 1 Watchman Blow The Gospel Trumpet.

OlivierJM commented

@TinasheMzondiwa Great work with this app.

Following up on @Burkifa23 's issue, Would it be okay to add guidelines on how other languages can be added, does automatically update if files are added in this repository in the matching format ?

TinasheMzondiwa commented

Hi @OlivierJM

I have created some issue templates you can use when suggesting a new language.

When adding a new language you'd follow the format in the existing languages. Open a PR and when I merge it would be available in the Android app, iOS takes a bit longer.

I was thinking ideally we'd have a simple web app you could upload the json file and it would render the content so you can easily verify the format etc but I am not a web developer and would need help on this.

Let me know if you have any suggestions.

  • 👍1
OlivierJM commented

Thanks for your quick comment @TinasheMzondiwa

I was thinking ideally we'd have a simple web app you could upload the json file and it would render the content so you can easily verify the format etc but I am not a web developer and would need help on this.

I can actually help with this, we'd have to decide on somethings like

  • where we upload to
  • expected format
  • etc ...
TinasheMzondiwa commented

Sounds good.

Let's discuss over in Slack.
Can I send you an invitation to the email address on your profile?

OlivierJM commented

Yes you can use that.

YewoMhango commented

I was thinking ideally we'd have a simple web app you could upload the json file and it would render the content so you can easily verify the format etc but I am not a web developer and would need help on this.

@TinasheMzondiwa I'm a web developer as well. I created a basic web page which I have been using for previewing and editing some of the songs in my own contributions. I think it would even be possible to just build on that and create a more user-friendly web app which could be used to make contributions towards editing the songs

TinasheMzondiwa commented

@YewoMhango Does this web page do more that this one https://previewer-psi.vercel.app/ ?
If so we could combine this into one source

YewoMhango commented

@TinasheMzondiwa I use mine for editing as well, so it renders the HTML as "contenteditable" to allow editing it almost like WYSIWYG. But it's kinda basic, without all the bells and whistles (and convenience) of a fully-fledged editor, since I was just using it personally. But I could work on it to make it a more refined WYSIWYG editor for this specific use case

  • 👍1
TinasheMzondiwa commented

@YewoMhango Sounds good, please let us know when you have something ready.

Or @OlivierJM could share with you the code for the preview app and we improve that one.

  • 👍1
YewoMhango commented

@TinasheMzondiwa okay. I'll work on an update and share it with you

  • 👍2
OlivierJM commented

@YewoMhango Let me know in case you need help, I think it's great being able to directly edit the JSON files, and by the way you could use TinyMCE I use it in some projects and it works well, it's easier to use and looks great.

  • 👍1
YewoMhango commented

@OlivierJM thanks a lot. I found the previewer repository which you made and I've just forked it, so I'm making the changes there. And since it uses Mantine, I have chosen to use the Tiptap editor which is already integrated with Mantine

  • ❤️1
OlivierJM commented

Awesome

YewoMhango commented

@OlivierJM @TinasheMzondiwa you may check it out here:

https://cis-previewer.vercel.app/

I've also created a pull request to the original codebase, and my fork can be found here:

https://github.com/YewoMhango/cis-previewer

I'd like to get your ideas, suggestions, or any problems you might notice

  • ❤️2
OlivierJM commented

@YewoMhango This looks great.

@TinasheMzondiwa Maybe we can make some few improvements and move on to having a web based hymn.

TinasheMzondiwa commented

@YewoMhango This is beautiful.

Good point @OlivierJM I have a domain I bought long ago and we can use it for this.

@YewoMhango What email address can I use to invite you to our Slack so we can discuss this?

YewoMhango commented

@TinasheMzondiwa wow, thanks. My email is this one: mhangoyewoh@gmail.com

  • 👍2