Feedback

[dantaeusb]

I'm not sure if you need much feedback from people who are relatively new to PWA and React-Redux-TS stack, but I experienced some troubles starting with this PWA and think my feedback, in theory, could be valuable. If not, feel free to close this issue without any answer, I'm totally fine with that :)

Here are the things I found confusing:

1. Using 11th version of Next can cause problems with postcss-discard-comments, see: vercel/next.js#24882. I've locked my copy on 10th version;

2. In Header's Items component, code relies on a non-documented (and actually for some reason marked as deprecated) feature when <a> tag is automatically added to the string children, but not to components. This could be ok for long-term users, but was super confusing for me;

3. Naming convention for SCSS (JSS, I guess) modules in React is different, while usually in most cases I've seen css-modules styles with hyphens are imported as camelCase (even my IDE tried to camelCase class names), it doesn't work in this instance (and as I understood could not be configured that way). I decided to avoid destructing assignments of classes and stick to style['class-name'] instead. Maybe mentions or usages of this naming somewhere in the repo would be good;

4. Really doubt about including this one, but Notification declared twice, first as component, then as an interface. Personally I don't see a problem here, however at some point I was having Identifier 'Notification' has already been declared due to confusion between those two. I really don't see any necessity of changing that, but maybe worth thinking about a little.

Overall, I found this boilerplate repo very useful, thank you for publishing your work to everyone! I really tried to start developing on this stack several times for personal project, but only this time I can say that it was relatively successful attempt.

[dantaeusb]

Disregard that, I found that there's a special discussion page, which is definitely a better place for feedback. Sorry.