FGP_dTV cpu nonneg enforcement not working

Question

FGP_dTV cpu nonneg enforcement not working

mhquah opened this issue 4 years ago · 4 comments

When using FGP_dTV with pdhg, we have been trying to enforce non negative values but are still getting them. The issue does not seem to occur with FGP_TV. The PC we are testing on does not have gpu capability, so we have only been able to test cpu.

@ashgillman @paskino @epapoutsellis

Answer 1 · 2021-01-31T23:34:05.000Z

happy to submit a mwe if required

Answer 2 · 2021-02-01T09:05:44.000Z

It is very strange since the constraints are here for 2D and here for 3D. Could you share some code to test?

Answer 3 · 2021-02-11T00:11:54.000Z

I agree, I am quite unsure what's happening. Although perhaps its more pertinent to compare TV/dTV

https://github.com/vais-ral/CCPi-Regularisation-Toolkit/blob/4026724a9808cac901e73c67eb364b9b91ee2f58/src/Core/regularisers_CPU/FGP_dTV_core.c#L140

https://github.com/vais-ral/CCPi-Regularisation-Toolkit/blob/4026724a9808cac901e73c67eb364b9b91ee2f58/src/Core/regularisers_CPU/FGP_TV_core.c#L129

Answer 4 · 2021-02-11T03:37:24.000Z

Oh my, terribly sorry @epapoutsellis , but I think the cause of this error is entirely our fault. It appears that we have made an embarrassingly simple mistake - we assumed the argument order was the same between FGP_TV and FGP_dTV. We can chat about it further on the meeting tonight (or in the morning).