TomographicImaging/CIL

Check convergence in PDHG throws an error, and should be False by default

Opened this issue a month ago · 1 comments

MargaretDuff commented a month ago

Description

The continued mission to kill kwargs... we should delete these line:
https://github.com/TomographicImaging/CIL/blob/23187c9eebfc691a4d65178c37a6cf59b01a0d57/Wrappers/Python/cil/optimisation/algorithms/PDHG.py#L320C7-L321C37

lauramurgatroyd commented a month ago

check_convergence currently isn't usable because:

CIL/Wrappers/Python/cil/optimisation/algorithms/PDHG.py

Line 225 in 23187c9

super().__init__(**kwargs)

passes it to the Algorithm base class which throws an error:
Algorithm.init() got an unexpected keyword argument 'check_convergence'