Tonejs/Midi

Conflicting declarations since midi-file dependency update to 1.2.0

saintmatthieu opened this issue · 5 comments

saintmatthieu commented

package.json :
{ "dependencies": { "midi-file": "^1.1.2" }, }
A recent midi-file update to 1.2.0 has added an index.d.ts with declarations that now conflict with those in @tonejs/midi's src/midi-file.d.ts.

Vexcited commented

It can be fixed, if we set "midi-file": "1.1.2" so it doesn't update to 1.2.0 where there's conflicting types.

I actually tried to fix the types with 1.2.0 but seems so complicated for me 😭
I think keeping midi-file at 1.1.2 is a great temporary fix (?)

saintmatthieu commented

Sounds wise 😃

Vexcited commented

Currently, I saw that there's a new version of midi-file (1.2.2) that adds more types definitions.

I think we have now what we need to adapt @tonejs/midi to midi-file types.
I'll try to do it and push a pull request when I'll do that (but I promise nothing).

  • 👍1
saintmatthieu commented

Interesting. I gave integrating this new version a whack, but that means integrating interface changes, something that needs be done properly. If freezing midi-file to 1.1.2 works for me, well then ...

Vexcited commented

Freezing to 1.1.2 is a working temporary fix, but I'm still waiting the NPM package to be updated because with conflicting declarations I can't progress on my project.

Anyway, I'm trying to update the project with new types of midi-file.

Edit: I made a Pull Request fixing this issue. I hope it will be merged soon as I didn't had any errors when building or type checking it...