Tracktion/choc

Compile error in `midi::Message`

chrhaase opened this issue · 2 comments

chrhaase commented

I got an error when instantiating the equality operator.
Changing the implementation to something like

template <typename StorageType>
template <typename OtherStorage>
bool Message<StorageType>::operator== (const Message<OtherStorage>& other) const
{
    auto len1 = size();
    auto len2 = other.size();
    return len1 == len2 && memcmp (data(), other.data(), len1) == 0;
}

fixes it.

julianstorer commented

Ah, thanks for the heads-up - yes, looks like a typo, I'll push a fix!

  • 👍1
chrhaase commented

Great, thanks!