TravelMapping/Web

findroute.php does no longer work for railways

Closed this issue · 9 comments

michihdeu commented

https://tmrail.teresco.org/hb/findroute.php does not load anymore. Same issue with Firefox and Edge. It worked last week though. It's still fine for hwy .

Uncaught ReferenceError: findrouteSystems is not defined
    parseRouteInfo https://tmrail.teresco.org/lib/findroutefuncs.js:52
jteresco commented

I'm going to be traveling today but hope to take a look soon.

  • 👍1
michihdeu commented

No hurry, I just checked what needs to be done before going to production 😉

jteresco commented

It looks like the problem is the use of double quotes in a system name: Chicago "L".

This causes the JS code generated by findroute.php to have a syntax error. I can make a fix if we really want/need to support double quotes in system names, but the easy fix for now is to change that entry.

michihdeu commented

@Duke87ofST Is " essential for the system name or can we simply call it Chicago L or Chicago Elevated?

https://en.wikipedia.org/wiki/Chicago_%22L%22

Duke87ofST commented
michihdeu commented

Done. @jteresco you can close the issue when you will have run an update and checked findroute.php.

michihdeu commented

On second thought.... a data check might help, however, a the JS code fix seems to be the best solution to avoid that the issue might come again. So, I think we should be the issue open.

jteresco commented

I'd prefer disallowing double quotes and possibly a hard error if and when that happens.

michihdeu commented

Fine for me. Data check issue submitted. Closing.