Pin version to `0.5.1-d-build.1161`
Closed this issue · 10 comments
Describe the Bug
Currently, the version that the mod uses is 0.5.1-d-build.5. However, some mods specifically depend on version 0.5.1-d-build.1161 (the latest release). It would be good if the build number could be pinned to 1161.
Reproduction Steps
- Install the fork
- Install a mod such as Create: SandPaper Overhaul
- Cannot launch game due to Create: SandPaper Overhaul requiring specifically create version
0.5.1-d-build.1161
Expected Result
Game launches.
Screenshots and Videos
N/A
Crash Report or Log
N/A
Operating System
Linux
Mod Version
0.5.1d
Minecraft Version
1.20.1
Other Mods
https://modrinth.com/mod/create-sandpaper-overhaul, N/A
Additional Context
N/A
I am temporary fixing this for myself, via the following patch:
diff --git a/build.gradle b/build.gradle
index a83006992..7d834c3ca 100644
--- a/build.gradle
+++ b/build.gradle
@@ -13,8 +13,9 @@ plugins {
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
-String runNumber = System.getenv("GITHUB_RUN_NUMBER")
-String build = runNumber != null ? "build.$runNumber" : "local"
+// String runNumber = System.getenv("GITHUB_RUN_NUMBER")
+String build = "build.1161"
+// String build = runNumber != null ? "build.$runNumber" : "local"
version = "$mod_version-$build+mc$minecraft_version"
group = project.maven_groupLooks like this affects Create Deco Fabric 2.0.0+1.20.1 as well. Confirmed that your patch fixes it. (Though instead of changing build.gradle, I just set GITHUB_RUN_NUMBER at build time, which works great locally, but wouldn't work with GitHub Actions due to default environment variable precedence.)
Yes, create deco is another one that I ran into which relied on the build number.
I set it in the buildscript, as that's technically the """better solution""", but whatever (tho the real better solution would be for mods to not depend on the build number lmao)
Also Create Air Fabric has this error.
Any news about a better fix yet (besides the earlier patch)? It's been over a month since this issue opened
Would it be too much trouble to provide an explanation as to how to implement this patch? @solonovamax
I'd love to do this but I am not sure how.
I am temporary fixing this for myself, via the following patch:
diff --git a/build.gradle b/build.gradle index a83006992..7d834c3ca 100644 --- a/build.gradle +++ b/build.gradle @@ -13,8 +13,9 @@ plugins { sourceCompatibility = JavaVersion.VERSION_17 targetCompatibility = JavaVersion.VERSION_17 -String runNumber = System.getenv("GITHUB_RUN_NUMBER") -String build = runNumber != null ? "build.$runNumber" : "local" +// String runNumber = System.getenv("GITHUB_RUN_NUMBER") +String build = "build.1161" +// String build = runNumber != null ? "build.$runNumber" : "local" version = "$mod_version-$build+mc$minecraft_version" group = project.maven_group
@corbinpenguin I recommend just using a Fabric Dependency Override. Example: talrey/CreateDeco#105 (comment)
Would it be too much trouble to provide an explanation as to how to implement this patch? @solonovamax
I'd love to do this but I am not sure how.I am temporary fixing this for myself, via the following patch:
diff --git a/build.gradle b/build.gradle index a83006992..7d834c3ca 100644 --- a/build.gradle +++ b/build.gradle @@ -13,8 +13,9 @@ plugins { sourceCompatibility = JavaVersion.VERSION_17 targetCompatibility = JavaVersion.VERSION_17 -String runNumber = System.getenv("GITHUB_RUN_NUMBER") -String build = runNumber != null ? "build.$runNumber" : "local" +// String runNumber = System.getenv("GITHUB_RUN_NUMBER") +String build = "build.1161" +// String build = runNumber != null ? "build.$runNumber" : "local" version = "$mod_version-$build+mc$minecraft_version" group = project.maven_group
either use the dependency override (as suggested by @Poopooracoocoo), or follow these instructions
I made a build of it: https://github.com/Mukul1127/Create-Sodium-Fix
fixed in latest update